feat(clerk-js): Use Gate in OrganizationMembers#1849
Conversation
🦋 Changeset detectedLatest commit: b4128ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
force-pushed
the
ORG-249-members
branch
from
19f2137 to
dc38abe
Compare
| <Td> | ||
| {isAdmin ? ( | ||
| <Gate | ||
| permission={'org:memberships:manage'} |
There was a problem hiding this comment.
Is it possible to use a constant here? Have we introduced permissions in our types yet?
There was a problem hiding this comment.
@chanioxaris types exist, not sure what you are referring to.
the above code is the same as writing
<Gate permission='org:memberships:manage'/>There was a problem hiding this comment.
Something like the below, or we don't usually do that and rely on TS type safety instead?
import { PermissionOrgMembershipsManage } from '@clerk/types';
<Gate permission={PermissionOrgMembershipsManage}>
|
Avoid merging without double checking with the team first |
panteliselef
force-pushed
the
ORG-249-members
branch
from
dc38abe to
8eefc2e
Compare
panteliselef
force-pushed
the
ORG-249-members
branch
from
8eefc2e to
b4128ac
Compare
|
This PR has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
Description
This PR replaces the role based check with permission based checks inside the OrganizationMembers component
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/clerk-js@clerk/clerk-react@clerk/nextjs@clerk/remix@clerk/types@clerk/themes@clerk/localizations@clerk/clerk-expo@clerk/backend@clerk/clerk-sdk-node@clerk/shared@clerk/fastify@clerk/chrome-extensiongatsby-plugin-clerkbuild/tooling/chore